[question] TtlCacheBacking - SystemTime or Instant?

[tsnoam]

Hi,

I was looking at this crate, evaluating it for my use.
While examining the code of TtlCacheBacking I've noticed that it's using SystemTime in order to determine the age of a cached entry.

My question is, why SystemTime instead of Instance? Was this due to a problem which you've encountered?

The reason for my questions is a caveat with SystemTime which each call to SystemTime::now() translates to a system call (at least on Linux) - a relatively slow operation.
Under heavy load, the affect of this can be significant.
Instant, on the other hand, does not suffer from the same problem.

[ByteAlex]

Sorry, I have not received any notification about this issue.
Using SystemTime was just a stupid approach of mine, I was not aware of the performance impact of it.
I'll move it to an Instant instead!

[ByteAlex]

About to leave, - tests were passing. If you don't mind give it a shot and let me know if you encounter any issues with it or if it's good to go! :)

[ByteAlex]

Since there was no action on this ticket for more than 2 weeks and the PR was sitting there waiting for a review, I've went ahead and merged this, since I did not observe any issues myself.
In case you've further questions, please don't hesitiate to reopen the issue.

Thank you!

[tsnoam]

Hi,
Sorry for the delay. I somehow missed it.
Yes, the change looks great.

Thankyou!