Skip to content

chore: show host and user in inspector #2634

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

dhth
Copy link
Contributor

@dhth dhth commented Mar 18, 2025

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Changes

Fixes #1578.

Adds two new rows for HOST and USER info in the inspector. Looks like this:
image

@ellie
Copy link
Member

ellie commented Mar 19, 2025

Thank you! Could we process this field please, and display host and user on separate lines?

@dhth
Copy link
Contributor Author

dhth commented Mar 19, 2025

Thank you! Could we process this field please, and display host and user on separate lines?

Definitely. I've pushed a change for this.

Follow up: if, for whatever reason, History.hostname doesn't follow the pattern HOST:USER, should we show a fallback string in the TUI? Like <COULDNT_DETERMINE> or <UNKNOWN>?

@ellie
Copy link
Member

ellie commented Mar 19, 2025

It always does! A fallback like you suggest is fine, but will never be needed unless something else is broken.

The old sync method relied about each install having a unique ID, and we did that by $HOSTNAME:$USER

It's not needed for sync v2, but remains regardless

@dhth
Copy link
Contributor Author

dhth commented Mar 19, 2025

Gotcha. In that case, I'll leave it to be an empty string :)

@dhth
Copy link
Contributor Author

dhth commented Mar 19, 2025

Is there something I need to do to fix the two failing Nix tests?

Nevermind.

@dhth dhth force-pushed the show-host-and-user-in-inspector branch from 27f68c0 to b3d2d3e Compare March 20, 2025 11:38
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🙏

@ellie ellie merged commit 2a60c50 into atuinsh:main Mar 21, 2025
19 checks passed
@dhth dhth deleted the show-host-and-user-in-inspector branch March 25, 2025 07:55
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show host and user in the inspector
2 participants