Ensure repl scrolls on insert #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inserting forms into the repl, the buffer doesn't always scroll to show the new input and result. This has been fixed in CIDER in a similar way so bringing the same trick here. clojure-emacs/cider#2590
bbatsov
reviewed
Aug 7, 2022
| ;; font-lock the inserted code | ||
| (font-lock-ensure beginning end))) | ||
| (comint-send-input t t)))) | ||
| (with-selected-window (or (get-buffer-window inf-clojure-buffer) |
There was a problem hiding this comment.
I linked the CIDER PR that does the same thing. That points to https://stackoverflow.com/questions/13530025/emacs-scroll-automatically-when-inserting-text . If the point is not visible the (goto (point-max)) code won't actually scroll the buffer.
This change ensures that inserting into the repl will scroll the repl so you can see what you inserted and the result. Before this it only worked if the point was at the end and visible.
There was a problem hiding this comment.
Got it - admittedly I didn't read the PRs description, only the title. :D Might be good to mention this in some comment as well.
There was a problem hiding this comment.
on it! thanks! EDIT: done
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting forms into the repl, the buffer doesn't always scroll to
show the new input and result. This has been fixed in CIDER in a similar
way so bringing the same trick here.
clojure-emacs/cider#2590