Skip to content

Make full size nav breakpoint max of 960px #1704

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
chrisdel101 opened this issue Nov 30, 2024 · 3 comments
Open

Make full size nav breakpoint max of 960px #1704

chrisdel101 opened this issue Nov 30, 2024 · 3 comments
Labels
design Change, update, or fix for site UI (not content) enhancement help wanted

Comments

@chrisdel101
Copy link
Contributor

In #1590 I noted this issue.

Having the nav bar squish at this large breakpoint makes it both:

  • Annoying to use on a laptop, where the screen size is often set to around 850px (864px for me). User always has to manually open the nav to use it.
  • Makes it way harder to do development on laptop since full nav and dev tools do not fit on the screen together.

Breakpoint to full nav should kick in between 768-850px like before. Since the links do not fit at these sizes, was reason this change was made, fix needs to implement some solution to hide certain links (or something) to make this work.

@chrisdel101 chrisdel101 changed the title Make full nav breakpoint Max of 960px Make full size nav breakpoint max of 960px Nov 30, 2024
@bjohansebas bjohansebas added enhancement help wanted design Change, update, or fix for site UI (not content) labels Dec 1, 2024
@bjohansebas
Copy link
Member

Links should not be hidden directly; the option to continue viewing those links should be added through a button. One idea is how GitHub handles it:
image
image

@bjohansebas
Copy link
Member

The design broke again, but the good thing is that now we only need to make changes in a single file to modify the header.

Image

@chrisdel101
Copy link
Contributor Author

Hey @bjohansebas, looks like I'll be around for another week or so before being away for a bit.

Going to draft up the #1780 approach here to see how that works. Seems like a better idea rn, as long as nested dropdowns don't get too messy.

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
design Change, update, or fix for site UI (not content) enhancement help wanted
Projects
None yet
Development

No branches or pull requests

2 participants