Skip to content

Restore resource allocators from snapshot #5170

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
Manciukic opened this issue Apr 25, 2025 · 1 comment
Open

Restore resource allocators from snapshot #5170

Manciukic opened this issue Apr 25, 2025 · 1 comment

Comments

@Manciukic
Copy link
Contributor

What

Currently the ResourceAllocator is not restored from the snapshot, but its state is rebuilt by replaying allocations with ExactMatch (example).

Why

The current pattern for restoring the state is cumbersome and prone to error. For example, acpi and mptable allocations in the system memory are not replayed, meaning that the allocator state would be different after restore. It works fine for now because we don't allow for changing state after restore, but new features may be impacted by this, like hotplugging.

How

We should serialize its state in the snapshot, as proposed in rust-vmm/vm-allocator#40, and remove the replayed ExactMatch allocations.

Additional Details

@DakshinD
Copy link
Contributor

I can take this issue on as well due to relevance with the other.

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants