Skip to content

The halfCheck-checkbox selects (unselects) all hierarchy nodes only after 2 clicks in IE, Edge browsers #120

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
yehor-dykhov opened this issue Dec 20, 2018 · 2 comments
Labels

Comments

@yehor-dykhov
Copy link

yehor-dykhov commented Dec 20, 2018

Steps to reproduce:

Open reactCheckboxTree component in IE or Edje.

Select one nested item in the tree;
Click on a higher checkbox in a hierarchy to select all nodes.

Actual result:
The checkbox is still in the half-checked state after 1 click. Only after the second click, it is selected all inner nodes and this half-checked checkbox changed its state.

Expected result:
The half-checked checkbox must select all internal nodes after 1 click and change its state.

@yehor-dykhov yehor-dykhov changed the title Mixed state checkbox is checked off only after 2 clicks in IE, Edje browser Mixed state of checkboxes is selected (unselected) all hierarchy nodes only after 2 clicks in IE, Edje browsers Dec 20, 2018
@yehor-dykhov yehor-dykhov changed the title Mixed state of checkboxes is selected (unselected) all hierarchy nodes only after 2 clicks in IE, Edje browsers The halfCheck-checkbox selects (unselects) all hierarchy nodes only after 2 clicks in IE, Edje browsers Dec 20, 2018
@jakezatecky jakezatecky changed the title The halfCheck-checkbox selects (unselects) all hierarchy nodes only after 2 clicks in IE, Edje browsers The halfCheck-checkbox selects (unselects) all hierarchy nodes only after 2 clicks in IE, Edge browsers Dec 28, 2018
@jakezatecky
Copy link
Owner

Confirmed.

@jakezatecky
Copy link
Owner

Thanks for the report. IE/Edge treat indeterminate (half-check) states different than other browsers when DOM events are fired. Luckily, the solution did not require significant change.

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants