Merge pull request #100 from php-enqueue/bundle-auto-register-reply-exntesion

[bundle] Auto register reply extension.

Author: makasim

docs/bundle/config_reference.md

@@ -162,10 +162,14 @@ enqueue:
         default_processor_queue: default
         redelivered_delay_time: 0
     job:                  false
+    async_events:
+        enabled:              false
+        spool_producer:       false
     extensions:
         doctrine_ping_connection_extension: false
         doctrine_clear_identity_map_extension: false
         signal_extension:     true
+        reply_extension:      true
 ```
 
 [back to index](../index.md)

pkg/enqueue-bundle/DependencyInjection/Configuration.php

@@ -61,6 +61,7 @@ public function getConfigTreeBuilder()
                 ->booleanNode('doctrine_ping_connection_extension')->defaultFalse()->end()
                 ->booleanNode('doctrine_clear_identity_map_extension')->defaultFalse()->end()
                 ->booleanNode('signal_extension')->defaultValue(function_exists('pcntl_signal_dispatch'))->end()
+                ->booleanNode('reply_extension')->defaultTrue()->end()
             ->end()->end()
         ;
 

pkg/enqueue-bundle/DependencyInjection/EnqueueExtension.php

@@ -134,6 +134,10 @@ public function load(array $configs, ContainerBuilder $container)
         if ($config['extensions']['signal_extension']) {
             $loader->load('extensions/signal_extension.yml');
         }
+
+        if ($config['extensions']['reply_extension']) {
+            $loader->load('extensions/reply_extension.yml');
+        }
     }
 
     /**

pkg/enqueue-bundle/Resources/config/extensions/reply_extension.yml

@@ -0,0 +1,6 @@
+services:
+    enqueue.consumption.reply_extension:
+        class: 'Enqueue\Consumption\Extension\ReplyExtension'
+        public: false
+        tags:
+            - { name: 'enqueue.consumption.extension' }

pkg/enqueue-bundle/Tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -341,4 +341,39 @@ public function testSignalExtensionCouldBeDisabled()
             ],
         ], $config);
     }
+
+    public function testReplyExtensionShouldBeEnabledByDefault()
+    {
+        $configuration = new Configuration([]);
+
+        $processor = new Processor();
+        $config = $processor->processConfiguration($configuration, [[
+            'transport' => [],
+        ]]);
+
+        $this->assertArraySubset([
+            'extensions' => [
+                'reply_extension' => true,
+            ],
+        ], $config);
+    }
+
+    public function testReplyExtensionCouldBeDisabled()
+    {
+        $configuration = new Configuration([]);
+
+        $processor = new Processor();
+        $config = $processor->processConfiguration($configuration, [[
+            'transport' => [],
+            'extensions' => [
+                'reply_extension' => false,
+            ],
+        ]]);
+
+        $this->assertArraySubset([
+            'extensions' => [
+                'reply_extension' => false,
+            ],
+        ], $config);
+    }
 }

pkg/enqueue-bundle/Tests/Unit/DependencyInjection/EnqueueExtensionTest.php

@@ -449,6 +449,40 @@ public function testShouldNotLoadSignalExtensionServiceIfDisabled()
         self::assertFalse($container->hasDefinition('enqueue.consumption.signal_extension'));
     }
 
+    public function testShouldLoadReplyExtensionServiceIfEnabled()
+    {
+        $container = new ContainerBuilder();
+        $container->setParameter('kernel.debug', true);
+
+        $extension = new EnqueueExtension();
+
+        $extension->load([[
+            'transport' => [],
+            'extensions' => [
+                'reply_extension' => true,
+            ],
+        ]], $container);
+
+        self::assertTrue($container->hasDefinition('enqueue.consumption.reply_extension'));
+    }
+
+    public function testShouldNotLoadReplyExtensionServiceIfDisabled()
+    {
+        $container = new ContainerBuilder();
+        $container->setParameter('kernel.debug', true);
+
+        $extension = new EnqueueExtension();
+
+        $extension->load([[
+            'transport' => [],
+            'extensions' => [
+                'reply_extension' => false,
+            ],
+        ]], $container);
+
+        self::assertFalse($container->hasDefinition('enqueue.consumption.reply_extension'));
+    }
+
     public function testShouldAddJobQueueEntityMapping()
     {
         $container = new ContainerBuilder();

pkg/enqueue/Consumption/Extension/ReplyExtension.php

@@ -37,6 +37,7 @@ public function onPostReceived(Context $context)
 
         $replyQueue = $context->getPsrContext()->createQueue($replyTo);
 
+        $context->getLogger()->debug(sprintf('[ReplyExtension] Send reply to "%s"', $replyTo));
         $context->getPsrContext()->createProducer()->send($replyQueue, $replyMessage);
     }
 }

pkg/enqueue/Tests/Consumption/Extension/ReplyExtensionTest.php

@@ -12,6 +12,7 @@
 use Enqueue\Psr\PsrProducer;
 use Enqueue\Test\ClassExtensionTrait;
 use PHPUnit\Framework\TestCase;
+use Psr\Log\NullLogger;
 
 class ReplyExtensionTest extends TestCase
 {
@@ -129,6 +130,7 @@ public function testShouldSendReplyMessageToReplyQueueOnPostReceived()
         $context = new Context($contextMock);
         $context->setPsrMessage($message);
         $context->setResult(Result::reply($replyMessage));
+        $context->setLogger(new NullLogger());
 
         $extension->onPostReceived($context);
     }