Skip to content

Should enqueue/enqueue also be added to "require" in composer.json for DBAL package? #433

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
aarangara opened this issue Apr 27, 2018 · 1 comment
Labels

Comments

@aarangara
Copy link

aarangara commented Apr 27, 2018

I imported only dbal package using composer require enqueue/dbal and tested a simple example from the docs, but it failed to create the message since it cannot find the class Enqueue\Util\JSON

Then I looked into the DbalProducer class file and found that the class Enqueue\Util\JSON is part of the enqueue/enqueue package so I had to import enqueue/enqueue separately.

So since, enqueue/dbal package cannot work without importing enqueue/enqueue, should the enqueue/enqueue also be added to "require" in the composer.json for enqueue/dbal?

I can see that it's already present in "require-dev".

@aarangara aarangara changed the title Should enqueue/enqueue also become part of "require" in composer.json for DBAL package? Should enqueue/enqueue also be part of "require" in composer.json for DBAL package? Apr 27, 2018
@aarangara aarangara changed the title Should enqueue/enqueue also be part of "require" in composer.json for DBAL package? Should enqueue/enqueue also be added to "require" in composer.json for DBAL package? Apr 27, 2018
@makasim
Copy link
Member

makasim commented Apr 29, 2018

Dbal transport should not depend on enqueue/enqueue. The use of Enqueue\Util\JSON should be removed.

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants