Skip to content

Support complex data type in ExecuTorch #886

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Open
iseeyuan opened this issue Oct 13, 2023 · 2 comments
Open

Support complex data type in ExecuTorch #886

iseeyuan opened this issue Oct 13, 2023 · 2 comments
Labels
actionable Items in the backlog waiting for an appropriate impl/fix module: runtime Issues related to the core runtime and code under runtime/ triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@iseeyuan
Copy link
Contributor

iseeyuan commented Oct 13, 2023 •
edited
Loading

Currently complex data type is not supported in ExecuTorch runtime. Although the model may be rewritten to real number operations, but it would affect the user's development efficiency.

What is complex data type here?
It's the math number system with real and imaginary parts like c = x * i * y.

It's used in some operations in PyTorch, like RoPE embedding in LLM, or Fourier Transforms (FFT).
@JacobSzwejbka JacobSzwejbka added the enhancement Not as big of a feature, but technically not a bug. Should be easy to fix label Oct 18, 2023
@guangy10 guangy10 added actionable Items in the backlog waiting for an appropriate impl/fix feature triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module and removed enhancement Not as big of a feature, but technically not a bug. Should be easy to fix labels Oct 26, 2023
@cccclai cccclai mentioned this issue Dec 7, 2023
Open
@dbort dbort added the module: runtime Issues related to the core runtime and code under runtime/ label Feb 12, 2024
@jackzhxng jackzhxng removed the feature label Feb 21, 2025
@github-project-automation github-project-automation bot moved this to To triage in ExecuTorch Core Feb 21, 2025
@mergennachin
Copy link
Contributor

cc @swolchok - is this supported now?

@swolchok
Copy link
Contributor

swolchok commented Feb 26, 2025 •
edited
Loading

supported

that depends on your definition of "supported". can you do more than zero things with a tensor of complex dtype? yes -- you can call abs(). can you do more than one thing? not as far as I know.

@iseeyuan iseeyuan moved this from To triage to Backlog in ExecuTorch Core Mar 11, 2025
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Assignees
No one assigned
Labels
actionable Items in the backlog waiting for an appropriate impl/fix module: runtime Issues related to the core runtime and code under runtime/ triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
ExecuTorch Core
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
7 participants
@swolchok @mergennachin @dbort @iseeyuan @JacobSzwejbka @jackzhxng @guangy10