Skip to content

Wrong HandlerMapping ordering for GraphQL WebSocket configuration #37892

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Oct 16, 2023 · 0 comments
Closed

Wrong HandlerMapping ordering for GraphQL WebSocket configuration #37892

bclozel opened this issue Oct 16, 2023 · 0 comments
Assignees
@bclozel
Labels
type: bug A general bug
Milestone
3.2.0-RC1

Comments

@bclozel
Copy link
Member

bclozel commented Oct 16, 2023

As of spring-projects/spring-framework#30278, Spring Framework revisited the default ordering of the RouterFunctionMapping bean. The GraphQL WebSocket auto-configuration relied on a fixed order value for that bean so as to make the WebSocketHandlerMapping first.

We should fix the auto-configuration to make it first again and introduce a dedicated test to check for that.
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Assignees

@bclozel bclozel

Labels
type: bug A general bug
Projects
None yet
Milestone
3.2.0-RC1
Development

No branches or pull requests
1 participant
@bclozel