Skip to content

make test crashes due to JSClosure memory issues #129

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
MaxDesiatov opened this issue May 6, 2021 · 0 comments · Fixed by #133
Closed

make test crashes due to JSClosure memory issues #129

MaxDesiatov opened this issue May 6, 2021 · 0 comments · Fixed by #133
Labels
bug Something isn't working

Comments

@MaxDesiatov
Copy link
Contributor

I'm not sure why this isn't reproducible on CI, but I got it crashing off the latest code in the main branch with a simple make && make test, here's the full output:

Here's the full output:

cd IntegrationTests && \
	    CONFIGURATION=debug make test && \
	    CONFIGURATION=release make test
cd .. && npm run build

> javascript-kit-swift@0.10.1 build
> npm run build:clean && npm run build:ts


> javascript-kit-swift@0.10.1 build:clean
> rm -rf Runtime/lib


> javascript-kit-swift@0.10.1 build:ts
> cd Runtime; tsc -b

swift build --package-path TestSuites \
	            --product PrimaryTests \
	            --triple wasm32-unknown-wasi \
	            --configuration debug
[1/1] Linking PrimaryTests.wasm
mkdir -p dist
cp TestSuites/.build/debug/PrimaryTests.wasm dist/PrimaryTests.wasm
node bin/primary-tests.js
Fatal error: The function was already released: file JavaScriptKit/JSClosure.swift, line 143

Fatal error: release() must be called on JSClosure objects manually before they are deallocated: file JavaScriptKit/JSClosure.swift, line 97

Fatal error: The function was already released: file JavaScriptKit/JSClosure.swift, line 143

rm TestSuites/.build/debug/PrimaryTests.wasm
cd .. && npm run build

> javascript-kit-swift@0.10.1 build
> npm run build:clean && npm run build:ts


> javascript-kit-swift@0.10.1 build:clean
> rm -rf Runtime/lib


> javascript-kit-swift@0.10.1 build:ts
> cd Runtime; tsc -b

swift build --package-path TestSuites \
	            --product PrimaryTests \
	            --triple wasm32-unknown-wasi \
	            --configuration release
[1/1] Linking PrimaryTests.wasm
mkdir -p dist
cp TestSuites/.build/release/PrimaryTests.wasm dist/PrimaryTests.wasm
node bin/primary-tests.js
Fatal error: The function was already released: file JavaScriptKit/JSClosure.swift, line 143

Fatal error: release() must be called on JSClosure objects manually before they are deallocated: file JavaScriptKit/JSClosure.swift, line 97

Fatal error: The function was already released: file JavaScriptKit/JSClosure.swift, line 143

rm TestSuites/.build/release/PrimaryTests.wasm
@MaxDesiatov MaxDesiatov added the bug Something isn't working label May 6, 2021
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant