Skip to content

Fix regex for parsing linkedin array links #2274

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

th3fallen
Copy link

@th3fallen th3fallen commented Apr 25, 2025

The second replace was incorrect, resulting in a link like https://google.com] which failed zod validation

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of array-like CSV entries to ensure trailing brackets are correctly processed.

The second replace was incorrect, resulting in a link like `https://google.com]` which failed zod validation
Copy link

coderabbitai bot commented Apr 25, 2025

📝 Walkthrough

Walkthrough

A regular expression in the parseArrayLikeCSVEntry function within the CSV utility module was corrected. The previous pattern for matching a closing bracket at the end of a string was invalid. The update replaces it with a proper expression that accurately detects and removes a trailing bracket before the string is split by commas. No changes were made to the function's signature or to any exported or public entities.

Changes

File(s) Change Summary
libs/utils/src/namespaces/csv.ts Fixed the regular expression in parseArrayLikeCSVEntry to correctly match a closing bracket at the end of a string. No changes to function signature.

Poem

In the land of code where brackets roam,
A regex error found its home.
But now it's fixed, the match is right,
Arrays parsed true, from left to right.
With tidy strings and commas split,
The CSV bunny does a happy sit! 🐇

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
libs/utils/src/namespaces/csv.ts (1)

26-26: Great fix for the regex pattern!

This change correctly addresses the issue with parsing LinkedIn array links. The previous pattern was incorrectly trying to match a closing bracket at the end, which resulted in malformed links like https://google.com] that failed Zod schema validation.

A small optimization suggestion:

- csvEntry.replace(/^\[/, "").replace(/\]$/, "").split(",");
+ csvEntry.replace(/^\[/, "").replace(/]$/, "").split(",");

The closing square bracket ("]") doesn't need to be escaped outside of a character class, so /]$/ would work just as well and is slightly cleaner.

🧰 Tools
🪛 ESLint

[error] 26-26: /]$/ can be optimized to /]$/.

(unicorn/better-regex)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd21860 and a23dbfa.

📒 Files selected for processing (1)
  • libs/utils/src/namespaces/csv.ts (1 hunks)
🧰 Additional context used
🪛 ESLint
libs/utils/src/namespaces/csv.ts

[error] 26-26: /]$/ can be optimized to /]$/.

(unicorn/better-regex)

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant