Skip to content

php 7.2 compatibility and small fixes #23

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2018
Merged

php 7.2 compatibility and small fixes #23

merged 4 commits into from
Feb 7, 2018

Conversation

mjrider
Copy link
Contributor

@mjrider mjrider commented Jan 30, 2018

Proposed Changes

update phpunit and paratest for php 7.2 compatibility

other changes:

  • DealerDirect -> Dealerdirect
  • 2017 -> 2018
  • versioneye is gone

Robbert Müller added 4 commits January 30, 2018 13:59
@mjrider mjrider requested review from frenck and Potherca January 30, 2018 15:31
Potherca
Potherca approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does exactly what it says on the tin

@mjrider mjrider merged commit c68947c into master Feb 7, 2018
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@Potherca Potherca Potherca approved these changes

@frenck frenck Awaiting requested review from frenck

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjrider @Potherca