Skip to content

fix: init examples repo #337

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: init examples repo #337

merged 1 commit into from
Jul 9, 2024

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Jul 9, 2024 •
edited
Loading

Description

  • Uses a new init make target to init the submodule instead of updating it on install to avoid CI blowing up.
  • Fixes a variable in the recently added UPS test

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team July 9, 2024 19:20
@Justintime50 Justintime50 merged commit 3970032 into master Jul 9, 2024
8 checks passed
@Justintime50 Justintime50 deleted the init_examples branch July 9, 2024 19:47
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@nwithan8 nwithan8 nwithan8 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justintime50 @nwithan8 @jchen293