Skip to content

feat: adds new recommend_ship_date and estimate_delivery_date functions #338

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Jul 9, 2024

Description

  • Adds new shipment.recommend_ship_date, smartrate.recommend_ship_date, and smartrate.estimate_delivery_date functions

Testing

Adds new tests that work similarly to how previous smartrate tests work

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team July 9, 2024 21:35
jchen293
jchen293 previously approved these changes Jul 10, 2024
nwithan8
nwithan8 previously approved these changes Jul 10, 2024
@Justintime50 Justintime50 dismissed stale reviews from nwithan8 and jchen293 via 05fb39e July 10, 2024 18:57
@Justintime50 Justintime50 merged commit 8ea650a into master Jul 10, 2024
8 checks passed
@Justintime50 Justintime50 deleted the smartrate_service branch July 10, 2024 21:01
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants