Mutable list of platforms for extensibility #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daevaorn Hi Alexander, What's the rationale behind this change ? What's the advantage of having that as a list ? |
|
Extensibility:-) For example I can add additional platforms to that list. We have self-hosted GitHub instance and it will be very pleasant feature to use library with it. |
daevaorn
force-pushed
the
mutable-platforms
branch
from
1b4f7a4 to
cef0bd3
Compare
|
Up |
|
This feature has been implemented in @yakky 's fork githubparse in nephila/giturlparse@cef0bd3 This project of @AaronO is likely dead as there's not been an update in 3 years so @yakky 's fork might be a good alternative. |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.