Skip to content

fix: cryptography warning on int_to_bytes #119

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2022
Merged

fix: cryptography warning on int_to_bytes #119

merged 1 commit into from
Mar 26, 2022

Conversation

peppelinux
Copy link
Member

Fixes

cryptojwt/jws/dsa.py:6: CryptographyDeprecationWarning:
int_from_bytes is deprecated, use int.from_bytes instead from cryptography.utils import int_from_bytes

@peppelinux peppelinux requested review from jschlyter and rohe March 26, 2022 14:00
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2022

Codecov Report

Merging #119 (a82343b) into main (5b36ff0) will increase coverage by 3.57%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   77.66%   81.23%   +3.57%     
==========================================
  Files          41       41              
  Lines        4307     5277     +970     
  Branches      833     1272     +439     
==========================================
+ Hits         3345     4287     +942     
- Misses        700      704       +4     
- Partials      262      286      +24     
Impacted Files Coverage Δ
src/cryptojwt/jws/dsa.py 81.81% <100.00%> (ø)
src/cryptojwt/jwe/__init__.py 100.00% <0.00%> (ø)
src/cryptojwt/tools/keygen.py 0.00% <0.00%> (ø)
src/cryptojwt/tools/jwtpeek.py 0.00% <0.00%> (ø)
src/cryptojwt/jwe/jwe.py 87.50% <0.00%> (+0.10%) ⬆️
src/cryptojwt/jwk/__init__.py 78.39% <0.00%> (+1.06%) ⬆️
src/cryptojwt/jwk/rsa.py 78.90% <0.00%> (+2.07%) ⬆️
src/cryptojwt/jwk/x509.py 57.89% <0.00%> (+3.50%) ⬆️
src/cryptojwt/jwk/hmac.py 85.47% <0.00%> (+4.07%) ⬆️
src/cryptojwt/key_issuer.py 84.97% <0.00%> (+4.47%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b36ff0...a82343b. Read the comment docs.

rohe
rohe previously approved these changes Mar 26, 2022
Copy link
Collaborator

@jschlyter jschlyter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run isort + black, otherwise fine

@peppelinux
Copy link
Member Author

my bad @jschlyter, done!

@jschlyter jschlyter merged commit d172218 into main Mar 26, 2022
@jschlyter jschlyter deleted the crypto_warn branch March 26, 2022 18:01
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants