Skip to content

Prefer raw key to FernetEncrypter #122

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

jschlyter
Copy link
Collaborator

If a pre-derived key is supplied to FernetEncrypter, prefer that to password/salt.

@jschlyter jschlyter requested a review from rohe April 27, 2022 10:23
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #122 (1723845) into main (d172218) will increase coverage by 0.17%.
The diff coverage is 97.43%.

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   77.26%   77.44%   +0.17%     
==========================================
  Files          41       42       +1     
  Lines        4324     4362      +38     
  Branches      836      842       +6     
==========================================
+ Hits         3341     3378      +37     
  Misses        718      718              
- Partials      265      266       +1     
Impacted Files Coverage Δ
src/cryptojwt/jwe/fernet.py 97.36% <97.36%> (ø)
src/cryptojwt/jws/jws.py 80.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8aa7c...1723845. Read the comment docs.

@rohe rohe merged commit ec79b98 into IdentityPython:main Apr 27, 2022
@jschlyter jschlyter deleted the fernet_order branch April 27, 2022 13:47
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants