Skip to content

Changes necessary to allow the SD JWT package to build on this. #151

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 12 commits into from
Oct 15, 2023
Merged

Conversation

rohe
Copy link
Contributor

@rohe rohe commented Aug 4, 2023

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (361ecaa) 76.48% compared to head (a24f6d9) 76.22%.
Report is 13 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   76.48%   76.22%   -0.26%     
==========================================
  Files          44       44              
  Lines        4699     4745      +46     
  Branches      982     1000      +18     
==========================================
+ Hits         3594     3617      +23     
- Misses        810      823      +13     
- Partials      295      305      +10     
Files Coverage Δ
src/cryptojwt/jwe/jwe_ec.py 82.81% <ø> (ø)
src/cryptojwt/jwk/__init__.py 76.35% <ø> (-1.36%) ⬇️
src/cryptojwt/jwk/ec.py 74.67% <ø> (ø)
src/cryptojwt/jwk/okp.py 68.39% <ø> (ø)
src/cryptojwt/jws/jws.py 81.02% <100.00%> (+0.07%) ⬆️
src/cryptojwt/jwx.py 84.11% <100.00%> (ø)
src/cryptojwt/key_bundle.py 76.77% <ø> (-0.69%) ⬇️
src/cryptojwt/jwt.py 78.63% <92.68%> (+1.74%) ⬆️
src/cryptojwt/key_jar.py 75.64% <40.00%> (-0.47%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohe rohe requested review from jschlyter and peppelinux August 4, 2023 08:59
jschlyter
jschlyter previously approved these changes Aug 4, 2023
Copy link
Collaborator

@jschlyter jschlyter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some tests using the new features would be nice.

…the header parameter "typ".

New method: add_keys()
peppelinux
peppelinux previously approved these changes Sep 2, 2023
@rohe rohe requested review from jschlyter and peppelinux October 14, 2023 10:58
@rohe rohe merged commit 1e79713 into main Oct 15, 2023
@rohe rohe deleted the sdjwt2 branch October 15, 2023 07:13
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants