Do not attempt to connect to Unix sockets on Windows when host is not set #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
force-pushed
the
implicit-host-connection
branch
from
189e3aa to
ff97424
Compare
… set When the host is not passed explicitly to `connect()`, asyncpg tries to find a suitable socket in a few known directories. On Windows, where there are no file sockets, we should connect directly to `localhost` instead. Fixes: #184.
elprans
force-pushed
the
implicit-host-connection
branch
from
ff97424 to
1f08463
Compare
1st1
approved these changes
Sep 12, 2017
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the host is not passed explicitly to
connect(), asyncpg triesto find a suitable socket in a few known directories. On Windows, where
there are no file sockets, we should connect directly to 'localhost'
instead.
Fixes: #184.