Implement Record.get() #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
force-pushed
the
record-get
branch
2 times, most recently
from
7fb9732 to
6e008b3
Compare
1st1
reviewed
Jul 28, 2018
asyncpg/protocol/record/recordobj.c
Outdated
| record_item_by_name(ApgRecordObject *o, PyObject *item) | ||
| { | ||
| PyObject *mapped = PyObject_GetItem(o->desc->mapping, item); | ||
| if (mapped != NULL) { |
There was a problem hiding this comment.
if (mapped == NULL) { return NULL; }
1st1
reviewed
Jul 28, 2018
asyncpg/protocol/record/recordobj.c
Outdated
| if (!PyArg_UnpackTuple(args, "get", 1, 2, &key, &defval)) | ||
| return NULL; | ||
|
|
||
| val = record_item_by_name(o, key); |
There was a problem hiding this comment.
I'd actually make record_item_by_name return -1 or 0 and not use PyErr_ExceptionMatches
elprans
force-pushed
the
record-get
branch
2 times, most recently
from
49f2164 to
d3d5421
Compare
1st1
reviewed
Jul 30, 2018
asyncpg/protocol/record/recordobj.c
Outdated
|
|
||
| noitem: | ||
| _PyErr_SetKeyError(item); | ||
| return -2; |
There was a problem hiding this comment.
Let's use an enum type, please. It's hard to read the code with checks for -1 or -2.
`Record.get()` allows record objects to better masquerade as dicts. Fixes: #330.
1st1
approved these changes
Jul 30, 2018
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record.get()allows record objects to better masquerade as dicts.Fixes: #330.