Add support for symbolic units by normalizing them to SI units #2621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
changed the title
|
Are we planning to finish this? |
|
+1 for finishing this! |
|
Well it looks like tests were passing when I re-ran it, so let me re-run it again with the merge fix and I'll merge if it's passing. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @variables X(tt) [unit = u"L"] | ||
| DD = Differential(tt) | ||
| eqs = [DD(X) ~ p - d * X + d * X] | ||
| @test ModelingToolkit.validate(eqs) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test ModelingToolkit.validate(eqs) | |
| @test ModelingToolkit.validate(eqs) |
|
Thanks! |
|
Would it be possible to create a release that includes this change? Thanks! |
|
done |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2616