Remove incidence matrix from system show #3039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2178 > The incidence matrix is actually not useful for humans. I am just showing it because it looks cool. We can just disable it if it's confusing. I'm not even sure it's worth documenting, but who it's useful for is for the compiler writers since if structural simplification works, then you're good. Maybe it's useful for diagnosing singularities, but that should get a debugging page because someone would need to get introduced to what it is for it to be useful. So I keep it around as a `ModelingToolkit.incidence_matrix` function that can be easily queried, but it's removed from the default show.
YingboMa
reviewed
Sep 10, 2024
src/systems/abstractsystem.jl
Outdated
| @@ -876,7 +876,8 @@ end | |||
| """ | |||
| $(TYPEDSIGNATURES) | |||
|
|
|||
| Mark a system as completed. If a system is complete, the system will no longer | |||
| Mark a system as completed. A completed system is assumed to be a | |||
ChrisRackauckas
commented
Sep 10, 2024
|
I assume since you caught that you reviewed this and didn't have an issue with the removal, so I'll merge. |
|
Yeah, I am fine with this change. |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2178
The incidence matrix is actually not useful for humans. I am just showing it because it looks cool. We can just disable it if it's confusing.
I'm not even sure it's worth documenting, but who it's useful for is for the compiler writers since if structural simplification works, then you're good. Maybe it's useful for diagnosing singularities, but that should get a debugging page because someone would need to get introduced to what it is for it to be useful. So I keep it around as a
ModelingToolkit.incidence_matrixfunction that can be easily queried, but it's removed from the default show.