Skip to content

fix: fix assert_jac_length_header #3556

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

AayushSabharwal
Copy link
Member

Close #3554

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Apr 10, 2025

I can add something like the MWE in the issue as a test if we want, just not sure if exact numerical equality is something we (or SU) can guarantee in these cases.

@ChrisRackauckas
Copy link
Member

Let's add it as a test but put a comment to the PR and that it might be disabled in the future. Indeed, we cannot really guarantee that because LLVM could do optimizations that make it false, but at least for right now it seems like a good enough test.

@vyudu
Copy link
Member

vyudu commented Apr 10, 2025

Just so I understand what's the change in the header here that makes it work with the CSE? Is it appending the assert to the end of the function?

@AayushSabharwal
Copy link
Member Author

No. For CSE to work, it needs to get a symbolic expression. When you interpolate expr.body into a LiteralExpr, all CSE sees is a Julia Expr so it can't do anything.

@AayushSabharwal
Copy link
Member Author

SymbolicIndexingInterface test group fails because SciMLBase needs a hotfix

@ChrisRackauckas ChrisRackauckas merged commit b0c2295 into SciML:master Apr 11, 2025
78 of 88 checks passed
@AayushSabharwal AayushSabharwal deleted the as/jac-header-fix branch April 11, 2025 11:58
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small numeric error introduced in sparse jacobians
3 participants