Skip to content

Optimize whitespace in template by default (preserveWhitespace to false by default) #22027

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Closed
IgorMinar opened this issue Feb 5, 2018 · 4 comments
Closed

Optimize whitespace in template by default (preserveWhitespace to false by default) #22027

IgorMinar opened this issue Feb 5, 2018 · 4 comments
Labels
area: core Issues related to the framework runtime breaking changes feature Issue that requests a new feature

Comments

@IgorMinar
Copy link
Contributor

In #18401 we implemented preserveWhitespace compiler flag to fix #11679.

Initially we made this an opt-in because of a possibility of subtle breaking changes related to applying styles to DOM with whitespace suddenly stripped from most nodes.

Now that we verified that the negative impact of this change at Google has been minimal, we should go ahead and make https://github.com/angular/angular/issues/11679 option set to false by default.
@IgorMinar IgorMinar mentioned this issue Feb 5, 2018
Closed
6 tasks
@IgorMinar IgorMinar added this to the v6-candidates milestone Feb 5, 2018
@IgorMinar IgorMinar added feature Issue that requests a new feature breaking changes area: core Issues related to the framework runtime labels Feb 5, 2018
benbraou added a commit to benbraou/angular that referenced this issue Feb 6, 2018
@benbraou
feat(core): set preserveWhitespaces to false by default
5d32477 
Fixes angular#22027
@benbraou benbraou mentioned this issue Feb 6, 2018
Closed
3 tasks
benbraou added a commit to benbraou/angular that referenced this issue Feb 6, 2018
@benbraou
feat(core): set preserveWhitespaces to false by default
889d64b 
Fixes angular#22027
benbraou added a commit to benbraou/angular that referenced this issue Feb 6, 2018
@benbraou
feat(core): set preserveWhitespaces to false by default
65ef710 
Fixes angular#22027
benbraou added a commit to benbraou/angular that referenced this issue Feb 6, 2018
@benbraou
feat(core): set preserveWhitespaces to false by default
5ee92be 
Fixes angular#22027
benbraou added a commit to benbraou/angular that referenced this issue Feb 7, 2018
@benbraou
feat(core): set preserveWhitespaces to false by default
0eb0639 
Fixes angular#22027
@benbraou benbraou mentioned this issue Feb 12, 2018
Closed
3 tasks
benbraou added a commit to benbraou/angular that referenced this issue Feb 13, 2018
@benbraou
feat(core): set preserveWhitespaces to false by default
6135515 
Fixes angular#22027
@vicb vicb closed this as completed in f1a0632 Feb 16, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this issue Feb 23, 2018
@benbraou @jbogarthyde
feat(core): set preserveWhitespaces to false by default (angular#22046)
73850d4 
Fixes angular#22027

PR Close angular#22046
smdunn pushed a commit to smdunn/angular that referenced this issue Feb 28, 2018
@benbraou @smdunn809
feat(core): set preserveWhitespaces to false by default (angular#22046)
f58a08f 
Fixes angular#22027

PR Close angular#22046
leo6104 pushed a commit to leo6104/angular that referenced this issue Mar 25, 2018
@benbraou @leo6104
feat(core): set preserveWhitespaces to false by default (angular#22046)
07bb45a 
Fixes angular#22027

PR Close angular#22046
@StefanKern
Copy link

StefanKern commented Apr 24, 2018 •
edited
Loading

Hey, Issue #21049 list a number of complains where this is change causes problems

@trotyl trotyl mentioned this issue May 8, 2018
Closed
@pfeigl pfeigl mentioned this issue May 19, 2018
Closed
jmleoni pushed a commit to jmleoni/angular that referenced this issue Oct 6, 2018
@benbraou @vicb
feat(core): set preserveWhitespaces to false by default (angular#22046)
3142add 
Fixes angular#22027

PR Close angular#22046
@simeyla
Copy link

simeyla commented Dec 23, 2018

{{ ' ' }}

@listepo-alterpost
Copy link

Hello, @IgorMinar why it doesn't work for TestBed by default?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
No Sign up for free to subscribe to this conversation on GitHub. Already have an account? No Sign in.
Assignees
No one assigned
Labels
area: core Issues related to the framework runtime breaking changes feature Issue that requests a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): set preserveWhitespaces to false by default benbraou/angular
4 participants
@IgorMinar @StefanKern @simeyla @listepo-alterpost