fix: Save task seatunnel error #14129
Conversation
zhongjiajie
changed the title
zhongjiajie
requested review from
EricGao888,
songjianet,
caishunfeng,
SbloodyS and
zhuangchong
as code owners
zhongjiajie
changed the title
| public enum EngineEnum { | ||
|
|
||
| FLINK("${SEATUNNEL_HOME}/bin/start-seatunnel-flink.sh"), | ||
| SPARK("${SEATUNNEL_HOME}/bin/start-seatunnel-spark.sh"), |
There was a problem hiding this comment.
delete the enum class due to seatunnel changing its startup script, so currently we have to support
seatunnel.sh
start-seatunnel-flink-13-connector-v2.sh
start-seatunnel-flink-15-connector-v2.sh
start-seatunnel-flink-connector-v2.sh
start-seatunnel-flink.sh
start-seatunnel-spark-2-connector-v2.sh
start-seatunnel-spark-3-connector-v2.sh
start-seatunnel-spark-connector-v2.sh
start-seatunnel-spark.sh
nine startups in both frontend and backend. Since we do not know whether seatunnel will change their startup script in the future or not. So I think we should remove this enum and just use the startup script name from front-end. please notice we do not ask users manually enter the startup script name because we provide drop-down box for it. Add this just for reducing the code change scope when startup script adding/changing
There was a problem hiding this comment.
for reviewer, we have a discussion in #14131 (comment)
There was a problem hiding this comment.
The new scream shot look like this
| return new SeatunnelEngineTask(taskRequest); | ||
| assert seatunnelParameters != null; | ||
| String startupScript = seatunnelParameters.getStartupScript(); | ||
| if (startupScript.contains(STARTUP_SCRIPT_SPARK)) { |
There was a problem hiding this comment.
change from equal enums to startup script contain specific string or not
Codecov Report
@@ Coverage Diff @@
## dev #14129 +/- ##
============================================
- Coverage 38.39% 38.38% -0.01%
- Complexity 4456 4458 +2
============================================
Files 1223 1223
Lines 42543 42543
Branches 4715 4713 -2
============================================
- Hits 16334 16332 -2
Misses 24410 24410
- Partials 1799 1801 +2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* fix error when save task seatunnel * support all version of seatunnel startup script by using string instead of engine enum * Remove unnecessary code in task seatunnel
* fix error when save task seatunnel * support all version of seatunnel startup script by using string instead of engine enum * Remove unnecessary code in task seatunnel close apache#14114
|
SonarCloud Quality Gate failed. |
|
@zhuangchong do you have time to take a look with this PR? |
closed #14114