Skip to content

[Improvement][Alert] Alert plugin enhance fail message #15024

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 16, 2023
Merged

[Improvement][Alert] Alert plugin enhance fail message #15024

merged 8 commits into from
Oct 16, 2023

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Oct 13, 2023

@qingwli qingwli requested a review from caishunfeng as a code owner October 13, 2023 06:53
@qingwli qingwli self-assigned this Oct 13, 2023
@qingwli qingwli added the improvement make more easy to user or prompt friendly label Oct 13, 2023
@qingwli qingwli added this to the 3.2.1 milestone Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #15024 (2cf4ad2) into dev (33084d2) will decrease coverage by 0.02%.
The diff coverage is 87.50%.

❗ Current head 2cf4ad2 differs from pull request most recent head 3b5ad56. Consider uploading reports for the commit 3b5ad56 to get more accurate results

@@             Coverage Diff              @@
##                dev   #15024      +/-   ##
============================================
- Coverage     38.97%   38.95%   -0.02%     
+ Complexity     4612     4600      -12     
============================================
  Files          1232     1231       -1     
  Lines         43360    43354       -6     
  Branches       4795     4795              
============================================
- Hits          16899    16888      -11     
- Misses        24587    24594       +7     
+ Partials       1874     1872       -2
Files Coverage Δ
...olphinscheduler/plugin/alert/email/MailSender.java 49.66% <100.00%> (+0.68%) ⬆️
...eduler/plugin/alert/pagerduty/PagerDutySender.java 68.85% <100.00%> (+2.78%) ⬆️
...uler/plugin/alert/webexteams/WebexTeamsSender.java 77.92% <100.00%> (+1.53%) ⬆️
...dolphinscheduler/plugin/alert/http/HttpSender.java 47.22% <0.00%> (-0.67%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qingwli
Copy link
Member Author

qingwli commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.

qE0a44OX6s and others added 3 commits October 15, 2023 20:42
@qE0a44OX6s @SbloodyS
Update dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphins…
432b949 
…cheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java

Co-authored-by: xiangzihao <zihaoxiang@apache.org>
@qingwli
update
dfac125
@qE0a44OX6s
Merge branch 'dev' into alert-log-enhance
3b5ad56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

Radeity
Radeity approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingwli qingwli merged commit 154e167 into apache:dev Oct 16, 2023
@qingwli qingwli deleted the alert-log-enhance branch October 18, 2023 05:50
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 30, 2023
@qE0a44OX6s @SbloodyS @xdu-chenrj
[Improvement][Alert] Alert plugin enhance fail message (apache#15024)
f752b9f 
* add webex && pagerduty fail log

* update

* fix spotless

* Update dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java

Co-authored-by: xiangzihao <zihaoxiang@apache.org>

* update

---------

Co-authored-by: xiangzihao <zihaoxiang@apache.org>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@Radeity Radeity Radeity approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

Assignees

@qingwli qingwli

Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

[Improvement][Alert] Alert plugin enhance fail message
5 participants
@qingwli @codecov-commenter @SbloodyS @Radeity @qE0a44OX6s