[TEST] fill up alert group service test #15777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abzymeinsjtu
force-pushed
the
feat_fillup_alert_group_svc_test
branch
from
1422530 to
a6ffef2
Compare
SbloodyS
requested changes
Mar 29, 2024
...heduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertGroupServiceTest.java
Outdated
Show resolved
Hide resolved
abzymeinsjtu
force-pushed
the
feat_fillup_alert_group_svc_test
branch
from
a6ffef2 to
3d52e86
Compare
abzymeinsjtu
force-pushed
the
feat_fillup_alert_group_svc_test
branch
from
dee5e33 to
35ec16d
Compare
EricGao888
previously approved these changes
Mar 29, 2024
abzymeinsjtu
dismissed stale reviews from SbloodyS, EricGao888, and rickchengx
via
dd30d16
abzymeinsjtu
force-pushed
the
feat_fillup_alert_group_svc_test
branch
from
da29528 to
dd30d16
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15777 +/- ##
============================================
+ Coverage 39.10% 39.15% +0.05%
- Complexity 4852 4862 +10
============================================
Files 1316 1316
Lines 44945 44945
Branches 4800 4800
============================================
+ Hits 17574 17599 +25
+ Misses 25479 25463 -16
+ Partials 1892 1883 -9 ☔ View full report in Codecov by Sentry. |
|
rickchengx
approved these changes
Mar 29, 2024
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
add test code to cover all alert group implement