Skip to content

Fix database schema change check failed with pg in ci #15995

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 2 commits into from
May 15, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented May 14, 2024

Purpose of the pull request

Fix https://github.com/apache/dolphinscheduler/actions/runs/9029128070/job/24812005661?pr=15967

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun requested a review from EricGao888 as a code owner May 14, 2024 10:04
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixDatabaseCheck branch from 4473f1a to 13373d1 Compare May 14, 2024 10:05
@ruanwenjun ruanwenjun added CI&CD bug Something isn't working labels May 14, 2024
@ruanwenjun ruanwenjun self-assigned this May 14, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone May 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.45%. Comparing base (b474563) to head (1f2c825).
Report is 5 commits behind head on dev.

❗ Current head 1f2c825 differs from pull request most recent head cddb1bb. Consider uploading reports for the commit cddb1bb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15995      +/-   ##
============================================
+ Coverage     39.91%   40.45%   +0.53%     
- Complexity     5083     5195     +112     
============================================
  Files          1370     1379       +9     
  Lines         45649    46093     +444     
  Branches       4869     4924      +55     
============================================
+ Hits          18223    18646     +423     
+ Misses        25527    25520       -7     
- Partials       1899     1927      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx merged commit 1a4537e into apache:dev May 15, 2024
69 of 70 checks passed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants