[DSIP-65] SubWorkflow logic task support pause/kill/recover #16566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_implementSubWorkflow
branch
from
012b1d3 to
31eeec4
Compare
ruanwenjun
force-pushed
the
dev_wenjun_implementSubWorkflow
branch
2 times, most recently
from
f2e6a05 to
33ec598
Compare
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_implementSubWorkflow
branch
from
33ec598 to
b7b5f99
Compare
|
caishunfeng
approved these changes
Sep 4, 2024
| taskInstance.setEndTime(new Date()); | ||
| taskInstanceDao.upsertTaskInstance(taskInstance); | ||
| super.pause(); | ||
| // todo: support pause |
There was a problem hiding this comment.
Dependent Task is very important in ds, so I think this is a high priority todo.
If it cannot be completed in a short time, I suggest to add some warn logs here.
There was a problem hiding this comment.
Yes, will use #16577 to fix this.
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16480
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md