Skip to content

[DSIP-38] Optimize dependency tree #16838

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 26, 2024
Merged

[DSIP-38] Optimize dependency tree #16838

merged 9 commits into from
Nov 26, 2024

Conversation

SbloodyS
Copy link
Member

@SbloodyS SbloodyS commented Nov 25, 2024 •
edited
Loading

Purpose of the pull request

close #16098

Brief change log

  • Removing plugin's repeated dependence in libs directory
  • Removing unused dependency
  • Removing data quality code was not deleted.

The binary package apache-dolphinscheduler-dev-SNAPSHOT-bin.tar.gz size is 912M with the following file

$ du -sh *
 72K    LICENSE
 84K    NOTICE
 44K    alert-server
 25M    api-server
 16K    bin
4.0K    conf
247M    libs
5.5M    licenses
 48K    master-server
 12K    mvnw
8.0K    mvnw.cmd
721M    plugins
 26M    standalone-server
772K    tools
 25M    ui
 44K    worker-server

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added the DSIP label Nov 25, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Nov 25, 2024
@SbloodyS SbloodyS self-assigned this Nov 25, 2024
@github-actions github-actions bot added UI ui and front end related backend test labels Nov 25, 2024
@github-actions github-actions bot removed the test label Nov 25, 2024
@github-actions github-actions bot removed the UI ui and front end related label Nov 25, 2024
@github-actions github-actions bot added the e2e e2e test label Nov 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ruanwenjun
ruanwenjun approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caishunfeng
caishunfeng approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS merged commit 9d9517a into apache:dev Nov 26, 2024
70 of 71 checks passed
@SbloodyS SbloodyS deleted the improvement_16098 branch November 26, 2024 09:45
@eco8848 eco8848 mentioned this pull request Feb 11, 2025
Open
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@songjianet songjianet Awaiting requested review from songjianet

@Gallardot Gallardot Awaiting requested review from Gallardot Gallardot is a code owner

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

Assignees

@SbloodyS SbloodyS

Labels
backend DSIP e2e e2e test ready-to-merge
Projects
None yet
Milestone
3.3.0-alpha
Development

Successfully merging this pull request may close these issues.

[Improvement] Optimize dependency tree
3 participants
@SbloodyS @caishunfeng @ruanwenjun