Skip to content

[IDE 1.5.x] Command-line / GUI refactor. #2328

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 73 commits into from
Nov 18, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
a601372
Explicitely store a layout type for a library
matthijskooijman Jul 7, 2014
af0d8c7
Let Sketch.getExtensions() return a List
matthijskooijman Jul 8, 2014
43dac3a
Use SketchCode.isExtension in more places
matthijskooijman Jul 8, 2014
e994c52
Don't store the extension in SketchCode
matthijskooijman Jul 8, 2014
9bc1824
Removed unused Base.getBoardsViaNetwork() and related member.
cmaglie Aug 26, 2014
dd911bc
Removed some trivial warnings
cmaglie Jan 26, 2014
026dd50
Removed some warning from Editor class
cmaglie Jan 26, 2014
479b974
Refactoring of Theme class
cmaglie Jan 26, 2014
93562a7
Refactored and simplified EditorConsole class.
cmaglie Jan 26, 2014
872897d
Splitted GUI and Streams in EditorConsole
cmaglie Jan 26, 2014
af19257
Rationalized Preferences and Theme classes.
cmaglie Jan 31, 2014
e6563cf
Removed GUI dependencies from SketchCode class.
bitron Jan 30, 2014
79ab98f
Make Compiler independent from Sketch.
bitron Jan 30, 2014
bbd3782
Reintroduced 'Next Tab' and 'Prev Tab' click actions
cmaglie Feb 1, 2014
54f3f53
Applied (a sort of) decorator pattern to SketchCodeDoc.
cmaglie Feb 1, 2014
b61f2a4
Made Compiler and PdePreprocessor independent from Preferences.
bitron Apr 5, 2014
21de7bd
Moved some code from Sketch to SketchData.
bitron Apr 7, 2014
18a8d4d
Created PApplet and PConstants wrapper classes.
cmaglie Aug 19, 2014
e0f680b
Drop dependency from processing-core project.
cmaglie Aug 19, 2014
50f89d9
Refactored OS detection subroutine.
cmaglie Aug 19, 2014
be96ae3
Removed no more used 'core' project
cmaglie Sep 24, 2014
057106f
Moved version info to BaseNoGui new class (work in progress).
bitron Aug 21, 2014
118826e
Moved getAvrBasePath() and related methods from Base to BaseNoGui (wo…
bitron Aug 21, 2014
7776ffa
Moved packages, currentDirectory and portableFolder (and related meth…
bitron Aug 21, 2014
4c1b187
Moved platform (and related methods) from Base to BaseNoGui (work in …
bitron Aug 21, 2014
4443911
Moved getBoardPreferences() and related methods from Base to BaseNoGu…
bitron Aug 21, 2014
64c6fe5
Moved saveFile() from Base to BaseNoGui (work in progress).
bitron Aug 21, 2014
c666274
Moved libraries and importToLibraryTable (and related methods) from B…
bitron Aug 21, 2014
e83462b
Changed dependency from Preferences to PreferencesData in processing.…
bitron Aug 21, 2014
1bb2da8
Moved some initialization code from Base to BaseNoGui.
bitron Aug 21, 2014
a43d207
Removed dependency from Base in the uploaders.
bitron Aug 21, 2014
fa0d37d
Added notifier interface and classes.
bitron Aug 21, 2014
d6bd77e
Removed dependency from Base in PreferencesData.
bitron Aug 21, 2014
bc6b488
Removed leftover references to Base in BaseNoGui.
bitron Aug 21, 2014
1c37189
Removed unused parameter (base).
bitron Aug 21, 2014
bff6f28
Renamed user notifier classes.
bitron Aug 21, 2014
74f59c2
Changed UserNotifier from interface to abstract class.
bitron Aug 21, 2014
eb28480
Moved showWarning() implementation from Base to BaseNoGui.
bitron Aug 21, 2014
b278c19
Removed dependency from Base in all Platform classes.
bitron Aug 22, 2014
22be22a
Removed self class references from Base.
bitron Aug 22, 2014
f2d92bb
Removed dependency from Preferences in a bunch of classes.
bitron Aug 22, 2014
b7d1846
Moved some code from Base to BaseNoGui and removed leftover self clas…
bitron Aug 22, 2014
afbbe77
Moved the sketch building code from Sketch to Compiler.
bitron Aug 22, 2014
5db851c
Moved the sketch structure check code from Editor to SketchData.
bitron Aug 22, 2014
1c8a4e9
Added sketch structure check to the build method of Compile.
bitron Aug 22, 2014
612f4c9
Moved discoveryManager from Base to BaseNoGui.
bitron Aug 22, 2014
7c58be3
Fixed wrong sketch structure check in Editor and SketchData.
bitron Aug 22, 2014
36fd0bf
Moved removeDescendants() and removeDir() from Base to BaseNoGui.
bitron Aug 22, 2014
4b69baa
Removed last dependency from Base in processing.app.Platform.
bitron Aug 22, 2014
b0d8a50
Moved isSanitaryName() and sanitizeName() from Sketch to BaseNoGui.
bitron Aug 22, 2014
0919b0e
Moved countLines() and loadFile() from Base to BaseNoGui.
bitron Aug 22, 2014
83c6137
Split UploaderAndMonitorFactory in two distinct classes.
bitron Aug 25, 2014
998142d
Moved last showError() method for Base to BaseNoGui.
bitron Aug 25, 2014
061d1f1
Moved the sketch uploading code from Sketch to Compiler.
bitron Aug 25, 2014
8687a78
Removed leftover dependency from SketchCodeDocument in SketchData.
bitron Aug 25, 2014
abe6ff5
Moved onBoardOrPortChange() and related members/methods from Base to …
bitron Aug 25, 2014
443f7a7
Moved some parameter processing methods from Base to BaseNoGui.
bitron Aug 25, 2014
10af59f
Moved some code from Base to BaseNoGui into new getSketchbookPath() m…
bitron Aug 26, 2014
2058263
Moved portableSketchbookFolder from Base to BaseNoGui.
bitron Aug 26, 2014
26a8b37
Refactored Base.getDefaultSketchbookFolder() method.
bitron Aug 26, 2014
035e57e
Moved getDefaultSketchbookFolder() from Base to BaseNoGui and other m…
bitron Aug 26, 2014
6d28e12
Moved commandline parsing code from Base/BaseNoGui to new Commandline…
bitron Aug 26, 2014
4d3599b
Moved getBuildFolder() and related members/methods from Base to BaseN…
bitron Aug 26, 2014
2702cce
Added main() and init() methods to BaseNoGui.
bitron Sep 10, 2014
c222310
Fixed wrong sketch structure check.
bitron Sep 18, 2014
b2a88ec
Removed inheritance relationship between SketchCodeDocument and Sketc…
bitron Sep 18, 2014
1974d77
Added new command line options.
bitron Sep 19, 2014
2de206c
Modified preferences initialization in BaseNoGui.
bitron Sep 23, 2014
ba8eade
Split IDE into 2 projects.
cmaglie Sep 23, 2014
d1f4e03
arduino-core project is now correctly compiled through ant build script
cmaglie Sep 24, 2014
98bdc7b
Moved specialized Platform classes and related resources to the 'ardu…
bitron Sep 25, 2014
820fc65
Created 'arduino-builder' project.
bitron Sep 25, 2014
7b2ed12
Temporarily disabled I18N test
cmaglie Oct 25, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .classpath
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<classpathentry excluding="processing/app/tools/format/|processing/app/tools/format/src/|processing/app/Trace.java|processing/app/RunnerClassLoader.java" kind="src" path="app/src"/>
<classpathentry kind="src" path="app/test"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
<classpathentry combineaccessrules="false" kind="src" path="/processing-core"/>
<classpathentry kind="lib" path="app/lib/antlr.jar"/>
<classpathentry kind="lib" path="app/lib/apple.jar"/>
<classpathentry kind="lib" path="app/lib/ecj.jar"/>
Expand All @@ -21,5 +20,6 @@
<classpathentry kind="lib" path="app/lib/jmdns-3.4.1.jar"/>
<classpathentry kind="lib" path="app/lib/jsch-0.1.50.jar"/>
<classpathentry kind="lib" path="app/lib/jssc-2.8.0.jar"/>
<classpathentry combineaccessrules="false" kind="src" path="/arduino-core"/>
<classpathentry kind="output" path="app/bin"/>
</classpath>
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
app/bin/
app/pde.jar
build/macosx/work/
core/bin/
core/core.jar
arduino-core/bin/
arduino-core/arduino-core.jar
hardware/arduino/bootloaders/caterina_LUFA/Descriptors.o
hardware/arduino/bootloaders/caterina_LUFA/Descriptors.lst
hardware/arduino/bootloaders/caterina_LUFA/Caterina.sym
Expand Down
4 changes: 3 additions & 1 deletion app/.classpath
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry excluding="processing/app/tools/format/" kind="src" path="src"/>
<classpathentry kind="src" path="test"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
<classpathentry kind="lib" path="lib/antlr.jar"/>
<classpathentry kind="lib" path="lib/jna.jar"/>
<classpathentry kind="lib" path="lib/ecj.jar"/>
<classpathentry combineaccessrules="false" kind="src" path="/processing-core"/>
<classpathentry kind="lib" path="lib/apple.jar"/>
<classpathentry kind="lib" path="lib/commons-codec-1.7.jar"/>
<classpathentry kind="lib" path="lib/commons-exec-1.1.jar"/>
Expand All @@ -14,5 +14,7 @@
<classpathentry kind="lib" path="lib/jmdns-3.4.1.jar"/>
<classpathentry kind="lib" path="lib/jsch-0.1.50.jar"/>
<classpathentry kind="lib" path="lib/jssc-2.8.0.jar"/>
<classpathentry kind="lib" path="test-lib/junit-4.11.jar"/>
<classpathentry combineaccessrules="false" kind="src" path="/arduino-core"/>
<classpathentry kind="output" path="bin"/>
</classpath>
9 changes: 3 additions & 6 deletions app/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<include name="*.jar"/>
</fileset>
<pathelement path="${env.JAVA_HOME}/lib/tools.jar"/>
<pathelement path="../core/core.jar"/>
<pathelement path="../arduino-core/arduino-core.jar"/>
</path>

<path id="class.path.test">
Expand All @@ -25,9 +25,9 @@

<target name="compile" description="Compile sources">
<condition property="core-built">
<available file="../core/core.jar" />
<available file="../arduino-core/arduino-core.jar" />
</condition>
<fail unless="core-built" message="Please build the core library first and make sure it sits in ../core/core.jar" />
<fail unless="core-built" message="Please build the Arduino-core library first and make sure it sits in ../arduino-core/arduino-core.jar" />

<mkdir dir="bin" />

Expand Down Expand Up @@ -80,9 +80,6 @@
includeAntRuntime="false"
debug="true"
classpathref="class.path" />
<copy todir="bin" overwrite="true" verbose="true">
<fileset dir="src" includes="**/*.properties" />
</copy>
</target>

<target name="test" depends="compile" description="Runs the test">
Expand Down
17 changes: 17 additions & 0 deletions app/src/cc/arduino/packages/MonitorFactory.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package cc.arduino.packages;

import processing.app.AbstractMonitor;
import processing.app.NetworkMonitor;
import processing.app.SerialMonitor;

public class MonitorFactory {

public AbstractMonitor newMonitor(BoardPort port) {
if ("network".equals(port.getProtocol())) {
return new NetworkMonitor(port);
}

return new SerialMonitor(port);
}

}
3 changes: 2 additions & 1 deletion app/src/processing/app/AbstractMonitor.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package processing.app;

import processing.app.debug.MessageConsumer;
import processing.core.PApplet;
import processing.app.legacy.PApplet;

import javax.swing.*;
import javax.swing.border.EmptyBorder;
Expand All @@ -14,6 +14,7 @@

import static processing.app.I18n._;

@SuppressWarnings("serial")
public abstract class AbstractMonitor extends JFrame implements MessageConsumer {

protected final JLabel noLineEndingAlert;
Expand Down
Loading