-
-
Notifications
You must be signed in to change notification settings - Fork 440
test: gRPC core client init integration test #2023
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
- Copied the env-variable server from Theia and made it possible to customize it for the tests. Each test has its own `data` folder. - Relaxed the primary package and library index error detection. This should make the init error detection locale independent. - Kill the daemon process subtree when stopping the daemon. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
57bc7d8
to
367ef9b
Compare
I've performed some tests by setting the locale to Tested it both by building the local branch and downloading the snapshot build generated from the github actions. Snapshot Build:Everything works as expected: the app launches successfully, the Local Branch:I've rebuilt everything with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Mac and everything works as expected.
Code LGTM ✅
Thanks, Akos!
## This PR must not be merged before theDone ✅2.1.0
release.Motivation
IDE2 needs integration tests to verify that the core gRPC client can be initialized for the CLI daemon. This PR is to ensure arduino/arduino-cli#2119 won't break anything.
Update:
it
andde
locales by relaxing the CLI error message parsing.Change description
data
folder.Other information
locale
tode
orit
in the CLI config, deletedirectories.data/library_index.json
, start IDE2, and open the library manager. It works. It's broken with2.1.0
. See the CLI configuration spec here if you cannot locate thedirectories.data
location.Reviewer checklist