Skip to content

Getting the same signatures as in atomic-rust #3

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Closed
joepio opened this issue Feb 6, 2021 · 1 comment
Closed

Getting the same signatures as in atomic-rust #3

joepio opened this issue Feb 6, 2021 · 1 comment

Comments

@joepio
Copy link
Member

joepio commented Feb 6, 2021

For some reason, I can't get the commit signatures to match with the rust implementation. The deteministic serialization works like it should, but something is going wrong with the signatures. I think the interfaces of Ring (for rust) and noble (js) are subtly different and I fail to see some important detail in which they are.
joepio added a commit that referenced this issue Feb 6, 2021
@joepio
Note in commit test #3
742fe1b
@joepio joepio mentioned this issue Feb 12, 2021
Closed
joepio added a commit that referenced this issue Feb 13, 2021
@joepio
YAY! Commits match with rust implementation #3
3f7efd9
@joepio
Copy link
Member Author

joepio commented Feb 17, 2021

Done!

@joepio joepio closed this as completed Feb 17, 2021
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joepio