Skip to content

GH-65 Fix "Paramters" typo #66

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2019
Merged

GH-65 Fix "Paramters" typo #66

merged 1 commit into from
Jan 2, 2019

Conversation

stepio
Copy link
Contributor

@stepio stepio commented Dec 26, 2018

Issue #65

Fixed a typo in method's naming, also did a search and fixed the same in a couple of comments.
Warning: as existing API methods are renamed, it's a breaking change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stepio
Copy link
Contributor Author

stepio commented Dec 30, 2018

Sorry, my bad, this almost duplicates #54, although I found and fixed one more occurrence in comments.

@mukhtar
Copy link
Contributor

mukhtar commented Jan 2, 2019

Thanks for the fix. (de)serialization doesn't seem to be impacted by the typos, however, it would be preferable to keep the existing methods with the typos for backwards compatibility, mark them as deprecated, and add two new methods with the fixes.

- keep the old methods for backward compatibility (marked as @deprecated)
- ignore folder with maven build results and IDEA-specific metadata
@stepio
Copy link
Contributor Author

stepio commented Jan 2, 2019

Thanks for feedback, you're right - it's safer to keep backward compatibility this way. Updated & force-pushed. Also slightly updated .gitignore file: added maven build folder and IntelliJ IDEA metadata files and folders.

@tphokas tphokas merged commit 7bf5fc9 into aws:master Jan 2, 2019
maxday added a commit that referenced this pull request Jun 28, 2024
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants