Skip to content

fix(chat): Fix unwanted destructive warning for the commands which not in the destructive commands list #7103

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
wants to merge 4 commits into
base: feature/agentic-chat
Choose a base branch
from

Conversation

Randall-Jiang
Copy link
Contributor

@Randall-Jiang Randall-Jiang commented Apr 18, 2025

Problem

Right now, when user run the commands outside the workspace, it would have destructive warning
image

Solution

Screen.Recording.2025-04-18.at.8.09.11.AM.mov

##To-do
For the special cases, will update the warning message as long as UX team share the design

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Randall-Jiang Randall-Jiang requested a review from a team as a code owner April 18, 2025 15:15
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Randall-Jiang Randall-Jiang requested a review from a team as a code owner April 18, 2025 19:00
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants