-
-
Notifications
You must be signed in to change notification settings - Fork 44
Use project detection code from clojure-mode #173
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Comments
I am not sure about this one. I have had "mixed" projects, like a single file ( I think what we really want is to detect the REPL type for a file for the above use case. It might be just me though so maybe we can just say we support "single type" projects and not mix types. It would be great to survey a bit usage of |
I was under the impression we want to drop the REPL type detection and just have users always specify it explicitly. The only reason for the project root is to know in which folder to start a REPL, although we can obvious prompt for this as well. //cc @dpsutton |
Oh ok yes that would definitely work here, however I still think that it can get a bit hairy cause you will have to fiddle with folders and Agree though that the current detection mechanisms is brittle and we should probably try something else (or drop it as already said). Simpler is better for sure. |
I think the project detection is pretty good actually. I think it would be better to show the detected repl type so its more easily correctable rather than making the user choose this each time. It will feel silly if you choose |
Why would you do something like this? If you choose |
Fair enough. We can set it automatically if the user uses one of the startup commands and otherwise we will offer a prompt after choosing. I'll get to it this weekend and also using the clojure-mode project directory stuff. thanks! |
I should be thanking you for tackling this! |
this should be resolved by #174 |
Probably it didn't exist back when I created
inf-clojure
. Now we can remove the custom code and simplifyinf-clojure
a bit.Adding a project name to each REPL might be the simplest way to having multiple REPLs support.
The text was updated successfully, but these errors were encountered: