Skip to content

Use comint-send-string #139

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

arichiardi
Copy link
Contributor

This one is solving the weird duplicating prompt issue. After the sanitation
patch we were sending newline twice. Using comint-send-string because it is
more low-level and does not modify the input string, which we are building
correctly already (hopefully).

See also #138.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our [contribution guidelines][1]
  • The new code is not generating bytecode or M-x checkdoc warnings

@arichiardi arichiardi force-pushed the use-comint-send-string branch from 73ab8dc to b10f38f Compare February 24, 2018 05:44
@arichiardi
Copy link
Contributor Author

This needs to be merged before the other one in order to avoid conflicts.

@arichiardi
Copy link
Contributor Author

No will have conflicts, tried locally.

@j0ni
Copy link

j0ni commented Feb 24, 2018

Hmm, I tried this tweak locally and though the immediate result is positive (only one prompt was output after evaluating a simple form), after about 20 seconds, during which I moved around two or three clj file buffers but didn't evaluate anything, three more prompts were printed out in the *inf-clojure* buffer.

No idea if it's related to the change, maybe this is another issue.

@j0ni
Copy link

j0ni commented Feb 24, 2018

(now I can't reproduce it 🤷‍♂️ )

@arichiardi
Copy link
Contributor Author

This goes in combination with the other PR, thanks for trying Btw!

@j0ni
Copy link

j0ni commented Feb 24, 2018

you're welcome - what else am I going to do on the weekend? 😛

By "other PR", do you mean #137 ?

@arichiardi
Copy link
Contributor Author

Yep, well I spent quite a bit of my night yesterday to try out solutions and this seems the most reliable. On which repl are you trying?

@j0ni
Copy link

j0ni commented Feb 24, 2018

I was using nREPL started via a leiningen project.

I'm out right now but later I'll try it with a socket repl.

@arichiardi
Copy link
Contributor Author

Ok let me know, folks trying other repls are invaluable given that I usually work with lumo

@bbatsov
Copy link
Member

bbatsov commented Mar 1, 2018

You'll have to rebase this. I missed the part about the order of the PRs.

@arichiardi
Copy link
Contributor Author

No worries, doing it now

This one is solving the weird duplicating prompt issue. After the sanitation
patch we were sending newline twice.  Using comint-send-string because it is
more low-level and does not modify the input string, which we are building
correctly already (hopefully).
@arichiardi arichiardi force-pushed the use-comint-send-string branch from b10f38f to b43f131 Compare March 1, 2018 01:17
@bbatsov bbatsov merged commit 9deb198 into clojure-emacs:master Mar 1, 2018
@arichiardi arichiardi deleted the use-comint-send-string branch March 1, 2018 01:18
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants