-
-
Notifications
You must be signed in to change notification settings - Fork 44
Use comint-send-string #139
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Use comint-send-string #139
Conversation
73ab8dc
to
b10f38f
Compare
This needs to be merged before the other one in order to avoid conflicts. |
No will have conflicts, tried locally. |
Hmm, I tried this tweak locally and though the immediate result is positive (only one prompt was output after evaluating a simple form), after about 20 seconds, during which I moved around two or three clj file buffers but didn't evaluate anything, three more prompts were printed out in the No idea if it's related to the change, maybe this is another issue. |
(now I can't reproduce it 🤷♂️ ) |
This goes in combination with the other PR, thanks for trying Btw! |
you're welcome - what else am I going to do on the weekend? 😛 By "other PR", do you mean #137 ? |
Yep, well I spent quite a bit of my night yesterday to try out solutions and this seems the most reliable. On which repl are you trying? |
I was using nREPL started via a leiningen project. I'm out right now but later I'll try it with a socket repl. |
Ok let me know, folks trying other repls are invaluable given that I usually work with |
You'll have to rebase this. I missed the part about the order of the PRs. |
No worries, doing it now |
This one is solving the weird duplicating prompt issue. After the sanitation patch we were sending newline twice. Using comint-send-string because it is more low-level and does not modify the input string, which we are building correctly already (hopefully).
b10f38f
to
b43f131
Compare
This one is solving the weird duplicating prompt issue. After the sanitation
patch we were sending newline twice. Using comint-send-string because it is
more low-level and does not modify the input string, which we are building
correctly already (hopefully).
See also #138.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
M-x checkdoc
warnings