Support joker

[arichiardi]

This patch introduces the defcustoms necessary for supporting joker.

---

Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our [contribution guidelines][1]
• The new code is not generating bytecode or M-x checkdoc warnings
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the readme (if adding/changing user-visible functionality)

[arichiardi]

@bbatsov what do you think if we release 2.2.0 after this is in?

[bbatsov]

Oh, that's interesting. That's support for the actual Joker! First I expected to see something related to linting.

Yeah, we can cut a new release afterwards.

[arichiardi]

This is pretty straightforward but I don't have access for publishing, only merging. No rush, testing it now ;)

[bbatsov]

So, everything looks good, but I'm starting to worry about our use of vars for every dialect we support, as this resulted in having a ton of them. Probably we should fold all the vars together and just have them point to an alist mapping forms to different dialects. This would also eliminate the need for all the pcases around the code - if all we had was an alist we can directly ask for the form matching our REPL type.

The only downside of this approach is that changing the defaults becomes a bit more complex, but I highly doubt that people do this often (if at all).

[arichiardi]

Yeah that would require quite a bit of refactoring - I don't think I can afford it at the moment. Inf-clojure is quite low in my list of open source to contribute to. I had a bunch of time when lumo was my main runtime but ... well ... things change 😄

[bbatsov]

This is pretty straightforward but I don't have access for publishing, only merging. No rush, testing it now ;)

Btw, that's pretty much the same. Releases happen automatically when you add a tag.

Yeah that would require quite a bit of refactoring - I don't think I can afford it at the moment. Inf-clojure is quite low in my list of open source to contribute to. I had a bunch of time when lumo was my main runtime but ... well ... things change 😄

Fair enough. Let's keep it as is.

[arichiardi]

Ok I will try to do it then.

So the plan is to change the CHANGELOG and commit with tag. Is that all?

[bbatsov]

Yep.

On Sat, 23 Mar 2019 at 19:44, Andrea Richiardi ***@***.***> wrote: Ok I will try to do it then. So the plan is to change the CHANGELOG and commit with tag. Is that all? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#160 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGVyqZ15ICZAWOlOpLvRGlGPxapjJToks5vZmgKgaJpZM4cEQGm> .

-- Best Regards, Bozhidar Batsov http://www.batsov.com