Handle newlines between forms for inf-clojure-eval-buffer
#188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Mar 15, 2021
inf-clojure.el
Outdated
| ;; newlines over a socket repl between top level forms cause | ||
| ;; a prompt to be returned. so here we dump the region into a | ||
| ;; temp buffer, and delete all newlines between the forms | ||
| (formatted (condition-case nil |
There was a problem hiding this comment.
That's seems a bit too complicated to me. Can't we just use the built-in delete-blank-lines or something like this?
There was a problem hiding this comment.
Actually, I see you tried to kill the blank lines only between top-level forms. That seems reasonable, but we should probably move this to some helper function, so it's clearer what it does (and we can add a test or two about it).
There was a problem hiding this comment.
will do tonight thanks!
|
@bbatsov the change is pretty big but look at the last commit. There were a bunch of poorly formatted tests so i just knocked those out. |
This sends the contents of the buffer. However, newlines cause the prompt to be returned. You can see this with even a regular clojure repl: ```bash ❯❯❯ clojure Clojure 1.10.2 user=> user=> user=> ``` (note using `clj` has rlwrap which hides a bit of this so make sure to use `clojure`). But what we can do is make sure to transform ```clojure (defn foo [] ...) (defn bar [] ...) ``` into ```clojure (defn foo [] ...) (defn bar [] ...) ``` So that the newlines don't trigger more repl prompts. Real world usage below: Before: ```clojure parse=> nil parse=> parse=> nil parse=> parse=> #'parse/data parse=> parse=> #'parse/parse-where parse=> parse=> #'parse/keywords parse=> parse=> #'parse/tokenize parse=> parse=> #'parse/parse parse=> parse=> #'parse/translate-where parse=> parse=> nil parse=> parse=> #'parse/query parse=> parse=> #'parse/query-test parse=> parse=> #'parse/bonus-points-test parse=> ``` After: ```clojure user=> nil parse=> nil parse=> #'parse/data parse=> #'parse/parse-where parse=> #'parse/keywords parse=> parse=> #'parse/parse parse=> #'parse/translate-where parse=> nil parse=> #'parse/query parse=> #'parse/query-test parse=> #'parse/bonus-points-test parse=> ```
|
Looks good. Thanks! |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends the contents of the buffer. However, newlines cause the
prompt to be returned. You can see this with even a regular clojure
repl:
(note using
cljhas rlwrap which hides a bit of this so make sure touse
clojure).But what we can do is make sure to transform
into
So that the newlines don't trigger more repl prompts. Real world usage below:
Before:
After: