[Fix #63] Avoid spurious output by using buffer redirection #69
Conversation
arichiardi
force-pushed
the
fix-spurious-output
branch
from
edb289d to
fd634a4
Compare
|
The problem with completions is that you have to post-process them in different ways depending on the repl type. For instance lumo returns json, which emacs can read. So completions need a better handling. |
inf-clojure.el
Outdated
| (set-process-filter proc comint-filt)) | ||
| eldoc)) | ||
| (let ((eldoc-snippet (format (inf-clojure-arglists-form) fn))) | ||
| (inf-clojure-results-from-process (inf-clojure-proc) (concat eldoc-snippet "\n")))) |
There was a problem hiding this comment.
Why don't you ensure the command ends with newline in inf-clojure-results-from-process?
There was a problem hiding this comment.
Yeah maybe that's better
inf-clojure.el
Outdated
| (setq is-matching (funcall match-p kept))) | ||
| (set-process-filter proc prev-filter)) | ||
| is-matching)) | ||
| (thread-last |
There was a problem hiding this comment.
The use of thread-last here seems pointless to me.
There was a problem hiding this comment.
The command was so long that is why I used it, I can remove it
arichiardi
force-pushed
the
fix-spurious-output
branch
from
fd634a4 to
62af115
Compare
|
Fixed the issue, I will need another sweep for fixing the problems with arglists and completions once and for all. Also, we could remove all the |
I will need to fix the arglists function as well, it does not work properly for edge cases, I already have some code ready, but I figured I should do another PR.
Also, the same approach should be used for completions, but completions require more work that is why I avoided putting it here.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
Thanks!