Skip to content

Fix #89 and speed #93

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2017
Merged

Fix #89 and speed #93

merged 2 commits into from
Jul 10, 2017

Conversation

arichiardi
Copy link
Contributor

Introduce double checking in the busy wait that detects if the inf-clojure process (the REPL) has completed and sent back everything. This removes the slowness that was triggered by having accept-process-output in the while body: we can take advantage now of its output to wait as well.

  • The commits are consistent with our [contribution guidelines][1]
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)

@arichiardi
Restyle inf-clojure-log-activity output
c4dac2d
@arichiardi
Improve performance of inf-clojure--process-response and close clojur…
cf2d968 
…e-emacs#89

Introduce double checking in the busy wait that detects if the inf-clojure
process (the REPL) has completed and sent back everything. This removes the
slowness that was triggered by having accept-process-output in the while body:
we can take advantage now of its output to wait as well.
@arichiardi arichiardi changed the title Fix 89 speed Fix #89 and speed Jul 10, 2017
@bbatsov bbatsov merged commit f7ec13a into clojure-emacs:master Jul 10, 2017
@bbatsov
Copy link
Member

bbatsov commented Jul 10, 2017

Just a small remark about the commit message style - when closing issues just prefix the commit title with [Fix #NNNN] ....

@bbatsov
Copy link
Member

bbatsov commented Jul 10, 2017

And great work overall! 👍

@arichiardi arichiardi deleted the fix-89-speed branch July 10, 2017 14:10
@arichiardi
Copy link
Contributor Author

Oh I always forget that right! Thanks for merging so quickly, inf-clojure is speedy again 😄

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arichiardi @bbatsov