Skip to content

Dynamic parameters #2

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Dynamic parameters #2

wants to merge 29 commits into from

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Apr 9, 2025

Emyrk and others added 29 commits March 14, 2025 12:09
@Emyrk
test(terraform): unit test that shows example of breaking derefs
be674f7 
Referencing a block that uses `count`, and accessing it's arguments
returns a nil value.
@Emyrk
simplier example
b43cac8
@Emyrk
most simple example
6921256
@Emyrk
chore: add tool to serialize back to hcl, nice for debugging
04605e2
@Emyrk
chore(terraform): save instances of data block to eval ctx as tuple
0103bd8 
Instances of a block were being saved as "<name>[<idx>] = val" to the
eval context. `expandBlocks` correctly saves it as a tuple
    "<name> = [val, ...]"
@Emyrk
add unit tests for ctylist
ce933c9
@Emyrk
remove dead code
6fe1164
@Emyrk
remove dead code
332c4ad
@Emyrk
some formatting
8f8e652
@Emyrk
chore: simplify looping behavior of 'insertTupleElement'
7271d20
@Emyrk
test: update test assertion to compare cty.Value not cty.Type
271dd05
@nikpivkin
fix: populate context correctly for resource instances with count
fbaa5b9 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
fix: populate context correctly for resource and data instances with …
a16013e 
…for_each

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@Emyrk
remove comment about not handled object case
91ded49
@Emyrk
linting fix
31084ec
@Emyrk
test(terraform): context setting also exists with module outputs
bac0ac4
@Emyrk
fix(terraform): correctly insert module output to eval context
f96d147
@Emyrk
Revert "fix(terraform): correctly insert module output to eval context"
a6d4c97 
This reverts commit f96d147.
@Emyrk
Revert "test(terraform): context setting also exists with module outp…
d2fff87 
…uts"

This reverts commit bac0ac4.
@Emyrk
simplify test require assertion
3ac5bfe
@Emyrk
fix(terraform): expand count blocks can depend on submodule returns
4f7ff4c 
Do not expand unknown `count` blocks. Run `expandBlocks` in eval to
allow submodule returns to affect the `count` when using module
outputs.
@Emyrk
update unit test
cd4d4b3
@Emyrk
test(terraform): add counter example test
fc4b5f5 
The depth of submodule evalutation is still limited
@Emyrk
fixup test
9b757cc
@Emyrk
test(terraform): add failing unit test with ambition to resolve
c6831f9 
Module counts are incorrectly being handled
@Emyrk
chore: check for unknown and null to match upstream change
6eb6063
@Emyrk
chore(terraform): hook into evaluateStep behavior with custom hooks
f035137 
evaluateStep handles many terraform semantics such as default
values for 'variables'. A hook into these steps allows defining
additional semantics, likely to mirror those of the actual provider
implementation.
@Emyrk
Merge remote-tracking branch 'emyrk/stevenmasley/module_output_count'…
cec73b7 
… into dynamic_parameters
@Emyrk
Merge remote-tracking branch 'emyrk/stevenmasley/count_argument_refer…
e6b004b 
…ences' into dynamic_parameters
@Emyrk Emyrk mentioned this pull request Apr 9, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @nikpivkin