Make comment annotations work #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!!! Do you mind updating the README file with this new flag? |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for issue #433. PR #459 implements the feature, but forgets to hook it up to either the rake task or the command line executable. I've added it to both☺️
I've also fixed a bug where
with_commentwould fail if any columns of a table were uncommented. The feature will also now turn itself off if a table has no comments at all.Rubocop complained about various complexity metrics on the
get_schema_infomethod, so I've moved a couple of bits of code into private methods. After that I've rebuilt.rubocop-todo.yml, which is looking a bit better than the last time it was generated. The only cop that's gotten worse isMetrics/BlockLength, which has gone up due to the increased size of theOptionParser.newblock inbin/annotate😬Thanks very much for this gem, I hope this PR will be useful to others 🙂