Skip to content

Ineffective configuration should error #117

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
jsphstls opened this issue Jan 7, 2020 · 2 comments · Fixed by #128
Closed

Ineffective configuration should error #117

jsphstls opened this issue Jan 7, 2020 · 2 comments · Fixed by #128
Labels
released type: enhancement New feature or request

Comments

@jsphstls
Copy link

jsphstls commented Jan 7, 2020

When I successfully run tests while trying to set up code coverage I can see a report such as this:

----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------

I clearly failed to properly configure my coverage collection but there is no indication of that failure.

These files are included in plugins:

  on('task', require('@cypress/code-coverage/task'))
  on('file:preprocessor', require('@cypress/code-coverage/use-babelrc'))

This is in support:

import '@cypress/code-coverage/support'

Could any of these tools throw if they were used but coverage was never processed?

@bahmutov
Copy link
Contributor

bahmutov commented Feb 4, 2020

Yes, I am thinking I should show an error in the command log and add a link to this repo

@bahmutov
Copy link
Contributor

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
released type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants