feat: warn if missing code coverage information #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea, will add note
…Sent from my iPhone
On Feb 4, 2020, at 11:22, Jennifer Shehane ***@***.***> wrote:
@jennifer-shehane commented on this pull request.
In support.js:
> @@ -53,9 +57,26 @@ if (Cypress.env('coverage') === false) {
windowCoverageObjects.forEach(cover => {
sendCoverage(cover.coverage, cover.pathname)
})
+
+ if (!hasE2ECoverage()) {
+ if (hasUnitTestCoverage()) {
+ cy.log(`👉 Only found unit test code coverage.`)
I think we should make these logs more specific to show that this logging is coming from the code-coverage plugin. People put a LOT of stuff in their repos and I'm afraid they'll see this random log and assume it's coming directly from Cypress somewhere. Thoughts to make this clearer:
Have this be like, a custom command that logs the command name as 'CODE COVERAGE'?
At the end of log say something like 'logged from code-coverage
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I have added the same test to every message coming from this plugin
|
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rndmerle
pushed a commit
to rndmerle/code-coverage
that referenced
this pull request
Apr 25, 2020
* feat: warn if missing code coverage information * add note to plugin's log messages
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a warning if cannot find neither e2e nor unit test code coverage. The warning has a link that opens on click right inside the test runner's browser, goes to https://github.com/cypress-io/code-coverage#instrument-your-application