Skip to content

sys/targets: add environment variable support for ARM64 triple config… #5869

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

happy2discover
Copy link

Instead of hard code ARM64 triple, a custom toolchain (e.g. aarch64-buildroot-linux-gnu) would be used sometimes


Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md


Copy link

google-cla bot commented Mar 28, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@happy2discover
Copy link
Author

@a-nogikh @tarasmadan could you please help to review? Thank you!

@tarasmadan
Copy link
Collaborator

Will symlink work for you?

@happy2discover
Copy link
Author

Will symlink work for you?

@tarasmadan yes, created symlinks to aarch64-buildroot-linux-gnu can work.

@tarasmadan
Copy link
Collaborator

Then the proposal is to use symlinks instead.
My motivation: it will be much harder to find this flag that to symlink the binary.
If we want to continue with syzkaller, it is better to enable this env variable for all the targets and extend documentation to make this new flag searchable.
Do you agree?

@dvyukov
Copy link
Collaborator

dvyukov commented Apr 1, 2025

If we want to continue with syzkaller, it is better to enable this env variable for all the targets and extend documentation to make this new flag searchable.

+1

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants