Skip to content

upgrade to Gradle 8.14 #10084

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

upgrade to Gradle 8.14 #10084

wants to merge 2 commits into from

Conversation

gavinking
Copy link
Member

amazingly, this appears to make my IntelliJ problems disappear!

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


amazingly, this appears to make my IntelliJ problems disappear!
@gavinking
Copy link
Member Author

Hrm, this breaks the tests for the Hibernate Gradle plugin.

@gavinking
Copy link
Member Author

Hrm, this breaks the tests for the Hibernate Gradle plugin.

Does this mean our plugin is incompatible with Gradle 8.14, or something more benign?

@gavinking
Copy link
Member Author

The problem appears to be something to do with this:

sourceSets {
    mySpecialSourceSet {
        java {
            srcDirs "src/mySpecialSourceSet/java"
        }
    }
}

hibernate {
    useSameVersion = false
    sourceSet = 'mySpecialSourceSet'

This works in Gradle 8.8, but apparently it's broken in 8.9 and above.

@sebersole It appears that this functionality has been deprecated for removal since HHH-16307. Can we just disable the test?

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Apr 25, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [e96d5db]

› This message was automatically generated.

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant