fix: properly pass in proxy to http client #1544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the typehint for the http client
Pull Request Type
Description
This PR makes it so that if no proxy URL and no proxy authentication was passed, the passed proxy to
HTTPClient
will beNone
instead of a tuple of(None, None)
. Having it be(None, None)
meant thatbool(proxy)
was always true, and so triggered a proxy check every time a bot started. My bots sometimes got hung up on this step when starting up (something about the WiFi where I live doesn't like it), so this bypass is nice.Also, the typehint for
HTTPClient
'sproxy
was adjusted to note how either the proxy URL or the proxy auth could be invalid, because why not.Changes
None
instead of a tuple ifproxy_url
andproxy_auth
areNone
intoHTTPClient
.HTTPClient
more accurate.Related Issues
Test Scenarios
Start up a bot. Literally. Look at the log and find if it tries to validate the proxy or not - it shouldn't attempt to.
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files