fix: Paginator.create_from_list no longer misses overflowing strings #1574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
When using
Paginator.create_from_list
with a list of strings that would exceed the page limit, the string that would cause the page overflow was removed, instead of being placed on the next page. This PR fixes this issue.Changes
Paginator.create_from_list
so that overflowing strings (that are not longer than the page limit) are placed at the beginning of the next page, instead of being removedRelated Issues
Test Scenarios
Use the following code inside a command callback:
Prior to this PR, executing the command would return two pages, with lines with a's and c's respectively. It now generates 4 pages, with one of the strings on each one.
Prior to this PR, executing this command would lead to an empty first page, and a second page with the c's. Now it leads leads to three non-empty pages with the b's, c's and d's.
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files